Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register detect public method #205

Closed
wants to merge 1 commit into from

Conversation

JoanClaret
Copy link
Contributor

@JoanClaret JoanClaret commented Nov 13, 2017

Defined detect public method in order to be able to use it in server side.

for instance:

import bowser from 'bowser'
[...]
const ua = bowser.detect(userAgent)
domain.config('isMobile', ua.mobile)
[...]

i did not delete the private method because i don't know if this would break something.
let me know if it's fine for you, or we can do it in an other better way.
Cheeers
Joan

@lancedikson
Copy link
Collaborator

Hey, @JoanClaret. Sorry for being late. Thanks for the PR, I'll merge it now.

@lancedikson
Copy link
Collaborator

I just wasn't so sure if we need this since it's better to make a new version works ASAP. But, it's, of course, better to have some public detection method.

@lancedikson
Copy link
Collaborator

It's been released as 1.9.0.

@JoanClaret
Copy link
Contributor Author

Great, thanks mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants