Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add toLowerCase option to getBrowserName in typing #409

Merged
merged 1 commit into from
Jun 1, 2020
Merged

add toLowerCase option to getBrowserName in typing #409

merged 1 commit into from
Jun 1, 2020

Conversation

pastak
Copy link
Contributor

@pastak pastak commented Mar 31, 2020

getBrowserName has toLowerCase option but it is lacked on typing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.486%
Totals Coverage Status
Change from base Build 880: 0.0%
Covered Lines: 568
Relevant Lines: 581
💛 - Coveralls

lancedikson
lancedikson approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for being so late. Will release soon!

@lancedikson lancedikson merged commit 8fe4b98 into bowser-js:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancedikson lancedikson lancedikson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pastak @coveralls @lancedikson