refactor: Do not allow to pass an alias to Pharaoh (#938)

box-project · Mar 19, 2023 · 14d647f · 14d647f
1 parent c7ca747
commit 14d647f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Pharaoh/Pharaoh.php b/src/Pharaoh/Pharaoh.php
@@ -69,7 +69,7 @@ final class Pharaoh
     private ?PharInfo $pharInfo = null;
     private ?string $path = null;
 
-    public function __construct(string $file, ?string $alias = null)
+    public function __construct(string $file)
     {
         Assert::readable($file);
         Assert::false(
@@ -83,7 +83,7 @@ public function __construct(string $file, ?string $alias = null)
         }
 
         // We have to give every one a different alias, or it pukes.
-        $alias ??= (Hex::encode(random_bytes(16)).'.phar');
+        $alias = (Hex::encode(random_bytes(16)).'.phar');
 
         $tmpFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$alias;
         copy($file, $tmpFile);