Bump XdebugHandler to min 3.x (#624)

composer.json

@@ -46,7 +46,7 @@
         "composer-plugin-api": "^2.2",
         "amphp/parallel-functions": "^1.1",
         "composer/semver": "^3.2",
-        "composer/xdebug-handler": "^2.0 || ^3.0",
+        "composer/xdebug-handler": "^3.0",
         "humbug/php-scoper": "^0.17",
         "justinrainbow/json-schema": "^5.2.9",
         "laravel/serializable-closure": "^1.0",

src/Console/Php/PhpSettingsHandler.php

@@ -33,8 +33,8 @@
  */
 final class PhpSettingsHandler extends XdebugHandler
 {
-    private $logger;
-    private $pharReadonly;
+    private LoggerInterface $logger;
+    private bool $pharReadonly;
 
     public function __construct(LoggerInterface $logger)
     {
@@ -55,13 +55,7 @@ public function check(): void
         parent::check();
     }
 
-    /**
-     * TODO: bump to XdebugHandler v3
-     * No type hint to allow XdebugHandler version 2.
-     *
-     * {@inheritdoc}
-     */
-    protected function requiresRestart($default): bool
+    protected function requiresRestart(bool $default): bool
     {
         if ($this->pharReadonly) {
             $this->logger->debug('phar.readonly is enabled');
@@ -74,11 +68,7 @@ protected function requiresRestart($default): bool
         return parent::requiresRestart($default);
     }
 
-    /**
-     * No type hint to allow XdebugHandler version 2
-     * {@inheritdoc}
-     */
-    protected function restart($command): void
+    protected function restart(array $command): void
     {
         // Disable phar.readonly if set
         $this->disablePharReadonly();
@@ -107,13 +97,13 @@ private function bumpMemoryLimit(): void
         $memoryLimit = trim(ini_get('memory_limit'));
         $memoryLimitInBytes = '-1' === $memoryLimit ? -1 : memory_to_bytes($memoryLimit);
 
-        // Whether or not the memory limit should be dumped
+        // Whether the memory limit should be dumped
         $bumpMemoryLimit = (
             null === $userDefinedMemoryLimit
             && -1 !== $memoryLimitInBytes
             && $memoryLimitInBytes < 1024 * 1024 * 512
         );
-        // Whether or not the memory limit should be set to the user defined memory limit
+        // Whether the memory limit should be set to the user defined memory limit
         $setUserDefinedMemoryLimit = (
             null !== $userDefinedMemoryLimit
             && $memoryLimitInBytes !== $userDefinedMemoryLimit