Don't start worker when unnecessary #135
Labels
Comments
theofidry
added a commit
to theofidry/box
that referenced
this issue
Apr 28, 2018
Starting Amp has an overhead and increase the likelyhood of rising an issue due to how Amp works. As a result, it is better to not have to start it unless necessary. So far the current compactors are fast enough to not require parallel processing, the build from Box without PHP-Scoper goes from 5s with parallel processing to 3s without. Closes box-project#135
theofidry
added a commit
that referenced
this issue
Apr 28, 2018
Starting Amp has an overhead and increase the likelyhood of rising an issue due to how Amp works. As a result, it is better to not have to start it unless necessary. So far the current compactors are fast enough to not require parallel processing, the build from Box without PHP-Scoper goes from 5s with parallel processing to 3s without. Closes #135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This needs some more benchmarking but I suspect that under a few thousand files even, if no compactor is enabled then starting the workers is likely to be a big useless overhead
The text was updated successfully, but these errors were encountered: