Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide official docker images for box #693

Closed
BigBadBassMan opened this issue Jul 27, 2022 · 4 comments · Fixed by #853
Closed

provide official docker images for box #693

BigBadBassMan opened this issue Jul 27, 2022 · 4 comments · Fixed by #853

Comments

@BigBadBassMan
Copy link

Feature Request

Since more and more projects adopt docker (for CI/CD or simply for build purposes), an official box docker-image (or collection of images for different supported PHP versions), available from hub.docker.com, would be beneficial.

These could be built and pushed by Github actions on each release.

@theofidry
Copy link
Member

I'm happy to merge it if there is an easy way to update the image on the docker hub on release 👍

@BigBadBassMan
Copy link
Author

I'm happy to merge it if there is an easy way to update the image on the docker hub on release +1

I'm trying to figure this out, the idea was that a release package triggers a docker action which builds and publishes the image.

May take awhile since I have not used Github Actions before.

@BigBadBassMan
Copy link
Author

So, this was not as complicated as I thought, the downside is: an account at hub.docker.com is needed to push, and its credentials (username & token) must be stored as secrets here.

The new workflow will download the latest release artifact after it has been published and bundle it as a docker image.

Open problems/questions remain:

  • It will run even on branches/pr's but still use only official packages, though.
  • docker "latest" is automatically assigned to each new built image - this may lead to problems, when releasing both 4.x and 3.x versions...

@theofidry
Copy link
Member

It will run even on branches/pr's but still use only official packages, though.

Can't it depend on the Build.publish-phar job to alleviate that issue?

docker "latest" is automatically assigned to each new built image - this may lead to problems, when releasing both 4.x and 3.x versions...

Maybe this could be solved by using a different image name? E.g. box3 & box4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants