feat: publish a docker image on release #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @BigBadBassMan, sorry it took so long |
|
@theofidry Thank you for continuing this. I'm ashamed to say, that I never got around to rework my PR and incorporate at least a barebone documentation - sorry. I had not dreamt that you would merge this, but I'm very thankful! |
|
There is no shame there, it was more than enough :) In the end I only had to do some tweaks due to heavy rework of the CI and some CS changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unfortunately could not take the username
humbugwhich would match the namespace for the packagist package, and docker hub does not accept dashes nor less than 4 character usernames.So the final name picked is
boxproject.This PR is a rebased version of #694.
Closes #694.
Closes #693.
Co-authored-by: Daniel Reiche daniel.reiche@check24.de