fix: Correctly check the PHARs equality #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
added a commit
to theofidry/box
that referenced
this pull request
Oct 11, 2023
Now that the equality check works as expected (see box-project#1049), we can simplify the way the diff command works by checking the equality once and skip the "archive" and "content" comparisons if the archives are equal.
theofidry
added a commit
that referenced
this pull request
Oct 11, 2023
Now that the equality check works as expected (see #1049), we can simplify the way the diff command works by checking the equality once and skip the "archive" and "content" comparisons if the archives are equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.