Upgrade Infection #472
Merged
Upgrade Infection #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 9.3 is compatible with PHP 8
phar.readonly is checked before restarting
|
From the logs I see that PHPUnit 9 is not used (PHPUnit 8 is still used). |
|
I change the goal of this PR because I think it's too early to upgrade PHPUnit mainly because Infection is incompatible with PHPUnit 9.3 for now. |
|
👌 |
theofidry
reviewed
Sep 11, 2020
| "mikey179/vfsstream": "^1.6", | ||
| "phpunit/phpunit": "^8.1", | ||
| "symfony/phpunit-bridge": "^4.2 || ^5.0" |
There was a problem hiding this comment.
out of curiosity why removing the bridge? I think its deprecation helper is quite helpful
There was a problem hiding this comment.
I thought the library was not used at all. I didn't think about the deprecation helper.
I can make another PR to put it back if you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
box compilewhen api.github.com returns a 301 code