Add PHP 7.4 image to the Dockerfile generator #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure is related to JetBrains/phpstorm-stubs#955 |
|
Cheers for the heads up, @smoench 🙂 |
theofidry
changed the title
|
@owenvoke Can you try a rebase? You will get a faster build with GitHub Actions and the phpstorm-stubs issue was resolved |
|
Sure, I'll rebase it in a couple of minutes. |
owenvoke
force-pushed
the
feature/php74-docker
branch
from
15f3f0f to
594c9e9
Compare
|
Looks like it's still expecting Travis to return a result. I guess that's in the settings? |
|
Yes, I'll remove it |
|
Thank you @owenvoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this works, I can't seem to get the tests to pass locally as it prompts for editor input. It looks like all builds passed on CI, except for one (https://travis-ci.org/github/box-project/box/builds/743917614).