Catch errors due to malformed tags #527
Conversation
| $doc = $this->factory->create($docblock); | ||
| } catch (InvalidArgumentException $e) { | ||
| // happens with malformed tags | ||
| return []; |
There was a problem hiding this comment.
@theofidry I'm not sure that returning an empty array here it's the best solution. Alternatively we can throw UnexpectedValueException, that way it will be caught in the PHP compactor. WDYT?
There was a problem hiding this comment.
let's go for a try/catch: it's slightly more explicit what is happening but it may be better with a custom exception (that can extend UnexpectedValueException)
There was a problem hiding this comment.
edit: it's not a big deal so feel free to ignore this if you don't want to spend more time on it
|
For some reasons looks like I never submitted my comment. Could you do a merge of the upstream? |
|
Thankyou @villfa |
|
Sorry for the delay and the lack of communication, I have been pretty busy in the last months. |
|
No worries :) |
Fix for #526