Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework configuration helper #661

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Rework configuration helper #661

merged 1 commit into from
Jun 19, 2022

Conversation

theofidry
Copy link
Member

The current configuration helper has several drawbacks:

  • It does several things: loading the config & locating the config
  • Is a "fake service" – a special console helper

In this PR:

  • The locating part of ConfigurationHelper is extracted into a dedicated ConfigurationLocator class
  • The remaining part of ConfigurationHelper has been renamed to ConfigurationLoader and no longer extends Helper

@theofidry theofidry merged commit 6bd2f85 into box-project:master Jun 19, 2022
@theofidry theofidry deleted the feature/config branch June 19, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry