Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Composer installation #695

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Fix for Composer installation #695

merged 1 commit into from
Sep 25, 2022

Conversation

kubawerlos
Copy link
Contributor

When humbug/box is installed via Composer then

require_once __DIR__.'/../vendor/composer/InstalledVersions.php';

(from https://github.com/box-project/box/blob/4.0.2/src/functions.php#L61)

fails as this files exist only when is used as PHAR.

Current behaviour can be seen in the failing check in PHP-CS-Fixer/PHP-CS-Fixer#6554.

@igorkgg
Copy link

igorkgg commented Aug 18, 2022

+1

@Zegnat
Copy link

Zegnat commented Sep 12, 2022

In waiting for this PR, I have been able to apply it through cweagans/composer-patches. Installation instructions from scratch:

composer config --no-plugins allow-plugins.bamarni/composer-bin-plugin true
composer require --dev bamarni/composer-bin-plugin
composer bin box config allow-plugins.cweagans/composer-patches true
composer bin box require --dev cweagans/composer-patches
composer bin box config --json extra.patches '{ "humbug/box": { "Fix for Composer installation": "https://github.com/box-project/box/pull/695.patch" } }'
composer bin box require --dev humbug/box

@theofidry theofidry merged commit 8a516af into box-project:master Sep 25, 2022
@theofidry
Copy link
Member

Thank you very much @kubawerlos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants