Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(requirement-checker): Make the Composer autoloader suffix deterministic #842

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

theofidry
Copy link
Member

Ideally the requirement checker extracted code (which is shipped in the Box PHAR) should only be changed if necessary, i.e. if:

  • the source code changes
  • a change in the scoping or Box occurrs which would result in a different artificat
  • a new version of Box occurs

Currently dumping several times in a row the requirement checker will result in different artifacts due to the Composer autoloader being random.

deterministic

Ideally the requirement checker extracted code (which is shipped in the
Box PHAR) should only be changed if necessary, i.e. if:

- the source code changes
- a change in the scoping or Box occurrs which would result in a
  different artificat
- a new version of Box occurs

Currently dumping several times in a row the requirement checker will
result in different artifacts due to the Composer autoloader being
random.
@theofidry theofidry enabled auto-merge (squash) January 29, 2023 13:16
@theofidry theofidry merged commit d306009 into box-project:main Jan 29, 2023
@theofidry theofidry deleted the feat/composer-staic branch January 29, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant