Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requirement-checker): Fix the constraint message displayed #876

Merged

Conversation

theofidry
Copy link
Member

  • When printing the constraint checked, the message shown should be the requirement message.
  • When priting the recommendations, the message shown should be the failed requirements help message.

The current final output now makes no sense (it is inversed), but this is because the messages set upstream are incorrect and they will be fixed separately.

- When printing the constraint checked, the message shown should be the
  requirement message.
- When priting the recommendations, the message shown should be the
  failed requirements *help* message.

The current final output now makes no sense (it is inversed), but this
is because the messages set upstream are incorrect and they will be
fixed separately.
@theofidry theofidry merged commit c0b00d1 into box-project:main Feb 12, 2023
@theofidry theofidry deleted the fix/req-checker-display-message branch February 12, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant