Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix the requirement checker PHP 8.3 job #911

Merged
merged 2 commits into from
Mar 4, 2023
Merged

ci: Fix the requirement checker PHP 8.3 job #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac4b284
ci: Fix the requirement checker PHP 8.3 job
theofidry Mar 4, 2023
8e8bcd9
fix
theofidry Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/requirement-checker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
working-directory: requirement-checker

- name: Ensure that the make target is up to date
run: cd requirement-checker; make vendor_install
run: cd requirement-checker; make _vendor_install

- name: Lint CS
run: cd requirement-checker; make cs_lint
Expand All @@ -69,7 +69,7 @@ jobs:
working-directory: requirement-checker

- name: Ensure that the make target is up to date
run: cd requirement-checker; make vendor_install
run: cd requirement-checker; make _vendor_install

- name: Run tests
run: cd requirement-checker; make phpunit_autoreview
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
composer-options: ${{ matrix.composer-options }}

- name: Ensure that the make target is up to date
run: cd requirement-checker; make vendor_install
run: cd requirement-checker; make _vendor_install

- name: Install the Composer (root) dependencies
uses: ramsey/composer-install@v2
Expand Down Expand Up @@ -295,7 +295,7 @@ jobs:
composer-options: ${{ matrix.php.composer-options }}

- name: Ensure that the make target is up to date
run: cd requirement-checker; make vendor_install
run: cd requirement-checker; make _vendor_install

- name: Install the Composer (root) dependencies
uses: ramsey/composer-install@v2
Expand Down
4 changes: 4 additions & 0 deletions requirement-checker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ test_e2e: docker_images _test_e2e_pass_no_config_min_composer_php _test_e2e_pass
.PHONY: vendor_install
vendor_install:
composer install --ansi
$(MAKE) _vendor_install

.PHONY: _vendor_install
_vendor_install:
touch -c vendor
touch -c $(PHPUNIT_BIN)

Expand Down