Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework extract command #961

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Mar 30, 2023

Dump extra information when extracting a PHAR. This is mostly the PHAR specific data that you can find (in different format sometimes) in the PHAR .phar directory. Dumping this information allows to get this information without keeping around a copy of the original PHAR and without using a Phar instance. This matters little for the extract command itself but that means later one we can get all the information of a PHAR by extracting it in a separate process and then not having to load a Phar instance anymore.

@theofidry theofidry marked this pull request as ready for review March 31, 2023 07:42
@theofidry theofidry merged commit f2e7e88 into box-project:main Mar 31, 2023
@theofidry theofidry deleted the refactor/extract branch March 31, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant