Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cosmetic changes to the Extract command #962

Merged
merged 7 commits into from
Mar 31, 2023
+4 −4
Merged

refactor: Cosmetic changes to the Extract command #962

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e64bc0b
fix
theofidry Mar 30, 2023
54a8206
cleanup
theofidry Mar 30, 2023
4568c52
reduce
theofidry Mar 30, 2023
8cd85d2
fix CS
theofidry Mar 30, 2023
70bfe3c
fix
theofidry Mar 30, 2023
9983d01
Merge remote-tracking branch 'upstream/main' into refactor/extract-ref
theofidry Mar 31, 2023
17d2a8e
revert
theofidry Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Console/Command/Extract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function getConfiguration(): Configuration
new InputArgument(
self::PHAR_ARG,
InputArgument::REQUIRED,
'The PHAR file.',
'The path to the PHAR file',
),
new InputArgument(
self::OUTPUT_ARG,
Expand All @@ -62,14 +62,14 @@ public function getConfiguration(): Configuration

public function execute(IO $io): int
{
$filePath = self::getPharFilePath($io);
$pharPath = self::getPharFilePath($io);
$outputDir = $io->getArgument(self::OUTPUT_ARG)->asNonEmptyString();

if (null === $filePath) {
if (null === $pharPath) {
return ExitCode::FAILURE;
}

self::dumpPhar($filePath, $outputDir);
self::dumpPhar($pharPath, $outputDir);

return ExitCode::SUCCESS;
}
Expand Down