Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Introduce a PharFactory and rework InvalidPhar #972

Merged
merged 8 commits into from
Apr 1, 2023
Merged

refactor: Introduce a PharFactory and rework InvalidPhar #972

merged 8 commits into from
Apr 1, 2023

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Mar 31, 2023 •
edited
Loading

Introduce a PharFactory service which will become the idiomatic way to instantiate a Phar or PharData instance.

@theofidry theofidry changed the title feat: Enrich the InvalidPhar exception refactor: Introduce a PharFactory and rework InvalidPhar Apr 1, 2023
@theofidry theofidry marked this pull request as ready for review April 1, 2023 12:45
@theofidry theofidry merged commit 72e5cef into box-project:main Apr 1, 2023
@theofidry theofidry deleted the feat/invalid-phar branch April 1, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry