Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Speed-up phar build process #119

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Speed-up phar build process #119

merged 1 commit into from
Dec 17, 2015

Conversation

mvrhov
Copy link
Contributor

@mvrhov mvrhov commented Nov 13, 2015

It helps if startBuffering is called when creating a new phar archive.
As the stopBuffering is called I suppose that someone missed the startBuffering directive.

The build times before and after...

time ../box/bin/box build
Building...

real    0m44.691s
user    0m21.601s
sys     0m13.337s

after

time ../box/bin/box build         Building...

real    0m24.135s
user    0m17.877s
sys     0m6.212s

Call the startBuffering method when building archive to speedup the phar building
@kherge
Copy link
Contributor

kherge commented Dec 17, 2015

I must have done something wrong since I didn't see any performance difference when I tested the use of that method. Better to have it than not since we all potentially stand to benefit from it!

Thanks!

kherge added a commit that referenced this pull request Dec 17, 2015
Speed-up phar build process
@kherge kherge merged commit c9ee902 into box-project:2.0 Dec 17, 2015
@mvrhov mvrhov deleted the patch-1 branch December 17, 2015 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants