This repository has been archived by the owner on Sep 6, 2020. It is now read-only.
Use SSL-enabled URI for manifest.json #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was using a non-SSL-enabled URI for the `manifest.json`, which could allow a MITM attack to provide an alternative file, and thus slipstream in insecure URIs for the `box.phar` locations. Considering the `manifest.json` uses SSL-enabled URIs for the PHAR downloads themselves, the assumption is already that PHP can perform the SSL/TLS negotiation, so there's no reason not to use the SSL/TLS for retrieving the manifest itself.
|
Excellent point. The use of HTTP is a carry over from when I still had the box-project.org domain and couldn't set up a proper SSL certificate for it. Thanks for the fix! |
kherge
added a commit
that referenced
this pull request
Dec 17, 2015
Use SSL-enabled URI for manifest.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script was using a non-SSL-enabled URI for the
manifest.json, which could allow a MITM attack to provide an alternative file, and thus slipstream in insecure URIs for thebox.pharlocations.Considering the
manifest.jsonuses SSL-enabled URIs for the PHAR downloads themselves, the assumption is already that PHP can perform the SSL/TLS negotiation, so there's no reason not to use the SSL/TLS for retrieving the manifest itself.