Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotations tooltip): Delete annotations tooltip #1533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(annotations tooltip): Delete annotations tooltip #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/i18n/en-US.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,6 @@ annotations_create_error=This annotation could not be created. Please try again.
annotations_delete_error=This annotation could not be deleted. Please try again.
# Text for when the authorization token is invalid
annotations_authorization_error=Annotations could not be loaded for this file. You may not have permission to take this action.
# Text for Tooltip content showing new users about annotations experience
annotations_tooltip_body=Make notes and comments to highlight key information when previewing content.
# Text for Tooltip title showing new users about annotations experience
annotations_tooltip_title=Add feedback on content

# Notifications
# Default text for notification button that dismisses notification
Expand Down
27 changes: 12 additions & 15 deletions src/lib/viewers/controls/annotations/AnnotationsControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React from 'react';
import noop from 'lodash/noop';
import { bdlBoxBlue } from 'box-ui-elements/es/styles/variables';
import AnnotationsButton from './AnnotationsButton';
import AnnotationsTargetedTooltip from './AnnotationsTargetedTooltip';
import IconDrawing24 from '../icons/IconDrawing24';
import IconExit24 from '../icons/IconExit24';
import IconHighlightText16 from '../icons/IconHighlightText16';
Expand Down Expand Up @@ -109,20 +108,18 @@ export default function AnnotationsControls({
>
<IconDrawing24 fill={isDrawingActive ? annotationColor : '#fff'} />
</AnnotationsButton>
<AnnotationsTargetedTooltip isEnabled={showRegion}>
<AnnotationsButton
ref={annotationBtnRefs[AnnotationMode.REGION]}
data-resin-target="highlightRegion"
data-testid="bp-AnnotationsControls-regionBtn"
isActive={annotationMode === AnnotationMode.REGION}
isEnabled={showRegion}
mode={AnnotationMode.REGION}
onClick={handleModeClick}
title={__('region_comment')}
>
<IconRegion24 />
</AnnotationsButton>
</AnnotationsTargetedTooltip>
<AnnotationsButton
ref={annotationBtnRefs[AnnotationMode.REGION]}
data-resin-target="highlightRegion"
data-testid="bp-AnnotationsControls-regionBtn"
isActive={annotationMode === AnnotationMode.REGION}
isEnabled={showRegion}
mode={AnnotationMode.REGION}
onClick={handleModeClick}
title={__('region_comment')}
>
<IconRegion24 />
</AnnotationsButton>
<AnnotationsButton
ref={annotationBtnRefs[AnnotationMode.HIGHLIGHT]}
data-resin-target="highlightText"
Expand Down
14 changes: 0 additions & 14 deletions src/lib/viewers/controls/annotations/AnnotationsTargetedTooltip.scss
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions src/lib/viewers/controls/annotations/AnnotationsTargetedTooltip.tsx
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions src/lib/viewers/controls/annotations/__tests__/AnnotationsTargetedTooltip-test.tsx
View file
Open in desktop

This file was deleted.