Chore: Rsync.plugin should update files rather than delete and replace #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is so that annotations.js/annotations.css and preview.js/preview.css can be synced from separate repositories simultaneously
tonyjin
reviewed
Aug 22, 2017
| @@ -10,7 +10,7 @@ RsyncPlugin.prototype.apply = function rsync(compiler) { | |||
| compiler.plugin('done', () => { | |||
| console.log(''); | |||
| console.log(`🔄 🔄 🔄 Rsync starting for ${this.source} 🔄 🔄 🔄`); | |||
| execSync(`rsync -avz --delete --exclude=".*" "${this.source}" "${this.destination}"`, { stdio: [0, 1, 2] }); | |||
There was a problem hiding this comment.
Note that this can potentially result in a lot of cruft if you change file names around or do some larger configuration change. Hypothetical, but this could cause a situation in which you can cause an error by changing the name of a referenced file but then not updating the name in code. Rsync wouldn't delete the old file on your VM, so your dev environment might still work, but would then break in staging/production.
There was a problem hiding this comment.
Hmm good point. Let me look into alternative setups
pramodsum
pushed a commit
to JustinHoldstock/box-content-preview
that referenced
this pull request
Jan 25, 2019
https://github.com/box/box-annotations/releases/tag/v3.7.1 * Update Translations (box#328) ([39805b8](box/box-annotations@39805b8)), closes [box#328](box/box-annotations#328) * Chore: Add escape hotkey on AnnotationPopover (box#327) ([e92ec85](box/box-annotations@e92ec85)), closes [box#327](box/box-annotations#327) * Fix: Highlight selection on Surface (box#326) ([6a3b83a](box/box-annotations@6a3b83a)), closes [box#326](box/box-annotations#326) * Fix: Import correct styling for flyout component (box#325) ([14d65f6](box/box-annotations@14d65f6)), closes [box#325](box/box-annotations#325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview.js/preview.css can be synced from separate
repositories simultaneously