Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace insensitive event types #785

Merged
merged 5 commits into from
Sep 9, 2021
Merged

Replace insensitive event types #785

merged 5 commits into from
Sep 9, 2021

Conversation

mhagmajer
Copy link
Contributor

No description provided.

@mhagmajer
Copy link
Contributor Author

Thanks for the review @mwwoda. I've restored the removed cases.

mwwoda
mwwoda previously approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it, but please check if it is possible to deprecate those old master* cases. I think we should discourage clients from using the old values.

@mhagmajer mhagmajer merged commit 1d06790 into main Sep 9, 2021
@mhagmajer mhagmajer deleted the mh/SDK-1697 branch September 9, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlawton jlawton jlawton left review comments

@mwwoda mwwoda mwwoda left review comments

@PJSimon PJSimon Awaiting requested review from PJSimon

@sujaygarlanka sujaygarlanka Awaiting requested review from sujaygarlanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhagmajer @jlawton @mwwoda