Rename uses of enterprise_token to enterprise_id #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jmoldow has signed the CLA. Thanks for the pull request! |
This parameter is referred to as enterprise_id in the Box Developer documentation. Also, the noun "token" is already used to refer to the data returned at the end of the auth process. So rename this to reduce confusion. This is a backwards compatible change, because the method parameter name was already correct. This is only a change to private attributes, test code, and documentation. Also add a temporary pip version exclusion on the latest version of pytest, which is broken on Python 2.
|
Looks good to me +2 |
potrebic
added a commit
that referenced
this pull request
Oct 3, 2015
Rename uses of enterprise_token to enterprise_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is referred to as
enterprise_idin the Box Developer documentation. Also, the noun "token" is already used to refer to the data returned at the end of the auth process. So rename this to reduce confusion.This is a backwards compatible change, because the method parameter name was already correct. This is only a change to private attributes, test code, and documentation.
Also add a temporary pip version exclusion on the latest version of pytest, which is broken on Python 2. See pytest-dev/pytest#1085 and pytest-dev/pytest#1035.