style(media): change to arrow fns from function keyword

box · Jul 12, 2019 · 5acbafe · 5acbafe
1 parent 9e6f93e
commit 5acbafe
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 34 deletions.
diff --git a/src/components/media/Media.js b/src/components/media/Media.js
@@ -15,14 +15,15 @@ type Props = {
     className?: string,
 };
 
-function Media({ as: Wrapper, children, className, ...rest }: Props) {
-    return (
-        <Wrapper className={classnames('bdl-Media', className)} {...rest}>
-            {children}
-        </Wrapper>
-    );
-}
+const Media = ({ as: Wrapper, children, className, ...rest }: Props) => (
+    <Wrapper className={classnames('bdl-Media', className)} {...rest}>
+        {children}
+    </Wrapper>
+);
 
+// Use this instead of default value because of param destructuring bug in Flow
+// that affects union types
+// https://github.com/facebook/flow/issues/5461
 Media.defaultProps = {
     as: 'div',
 };

diff --git a/src/components/media/MediaBody.js b/src/components/media/MediaBody.js
@@ -10,13 +10,10 @@ type Props = {
     className?: string,
 };
 
-function MediaBody(props: Props) {
-    const { className, children, ...rest } = props;
-    return (
-        <div className={classnames('bdl-Media-body', className)} {...rest}>
-            {children}
-        </div>
-    );
-}
+const MediaBody = ({ className, children, ...rest }: Props) => (
+    <div className={classnames('bdl-Media-body', className)} {...rest}>
+        {children}
+    </div>
+);
 
 export default MediaBody;
diff --git a/src/components/media/MediaFigure.js b/src/components/media/MediaFigure.js
@@ -12,14 +12,15 @@ type Props = {
     className?: string,
 };
 
-function MediaFigure({ as: Wrapper, className, children, ...rest }: Props) {
-    return (
-        <Wrapper className={classnames('bdl-Media-figure', className)} {...rest}>
-            {children}
-        </Wrapper>
-    );
-}
+const MediaFigure = ({ as: Wrapper, className, children, ...rest }: Props) => (
+    <Wrapper className={classnames('bdl-Media-figure', className)} {...rest}>
+        {children}
+    </Wrapper>
+);
 
+// Use this instead of default value because of param destructuring bug in Flow
+// that affects union types
+// https://github.com/facebook/flow/issues/5461
 MediaFigure.defaultProps = {
     as: 'figure',
 };

diff --git a/src/components/media/MediaMenu.js b/src/components/media/MediaMenu.js
@@ -19,17 +19,15 @@ type Props = {
     label?: string,
 };
 
-function MediaMenu({ className, children, isDisabled = false, label, ...rest }: Props) {
-    return (
-        <div className={classnames('bdl-Media-menu', className)} {...rest}>
-            <DropdownMenu constrainToScrollParent isRightAligned>
-                <PlainButton isDisabled={isDisabled} type="button" aria-label={label}>
-                    <IconEllipsis color={bdlGray62} height={16} width={16} />
-                </PlainButton>
-                <Menu>{children}</Menu>
-            </DropdownMenu>
-        </div>
-    );
-}
+const MediaMenu = ({ className, children, isDisabled = false, label, ...rest }: Props) => (
+    <div className={classnames('bdl-Media-menu', className)} {...rest}>
+        <DropdownMenu constrainToScrollParent isRightAligned>
+            <PlainButton isDisabled={isDisabled} type="button" aria-label={label}>
+                <IconEllipsis color={bdlGray62} height={16} width={16} />
+            </PlainButton>
+            <Menu>{children}</Menu>
+        </DropdownMenu>
+    </div>
+);
 
 export default MediaMenu;