chore(content-explorer): Migrate shareDialog #3735
Conversation
There was a problem hiding this comment.
do we need the flow files for the internal components of ContentExplorer? shouldn't the flow only be needed for the outer component that consumers use?
There was a problem hiding this comment.
do you think we should leave it out? its only there because i ran the codemod on it
| type="text" | ||
| value={url} | ||
| /> | ||
| <Button autoFocus className="be-modal-button-copy" onClick={copy} variant="primary"> |
There was a problem hiding this comment.
does button have autoFocus prop?
tsconfig.json
Outdated
| @@ -15,5 +15,6 @@ | |||
| "strict": false | |||
| }, | |||
| "files": [".storybook/typings.d.ts"], | |||
| "include": ["src/**/*.ts", "src/**/*.tsx", "examples/src/**.tsx", "types.ts", "scripts/jest/jest-setup.ts"] | |||
| "include": ["src/**/*.ts", "src/**/*.tsx", "examples/src/**.tsx", "types.ts", "scripts/jest/jest-setup.ts"], | |||
| "exclude": ["src/**/*.stories.ts", "src/**/*.stories.tsx"] | |||
There was a problem hiding this comment.
why do we want to exclude stories?
There was a problem hiding this comment.
it dawned on me that components and elements in stories do not need all the required props to demonstrate specific functions.
| > | ||
| <div className="be-modal-content"> | ||
| <Text as="label"> | ||
| <FormattedMessage tagName="div" {...messages.shareDialogText} /> |
There was a problem hiding this comment.
do we need tagName still? i assume it was originally added for some block level style but i'm not sure if it's necessary
There was a problem hiding this comment.
going to remove this that should be there
greg-in-a-box
force-pushed
the
sharedialog
branch
5 times, most recently
from
89360b1
to
54392aa
Compare
greg-in-a-box
force-pushed
the
sharedialog
branch
2 times, most recently
from
1728cfc
to
b8c0428
Compare
greg-in-a-box
force-pushed
the
sharedialog
branch
from
b8c0428
to
7d4a0ad
Compare
before:
after:
