Process reactions sent from other devices and messages containing profile keys #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before only reactions in message with profile_key=None would be processed. This caused reactions sent from own devices as well as some reactions in chats to be dropped.
hrdl-github
force-pushed
the
fix_reactions_self
branch
from
5ddc5eb to
63a8b3e
Compare
hrdl-github
changed the title
|
This partially addresses #147. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactions are handled at a later point. Alternatively, the match arm handling reactions could be moved up.Before only reactions in message with
profile_key=Nonewould beprocessed. This caused reactions sent from own devices as well as some
reactions in chats to be dropped.