Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some high-level help text & documentation #301

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

brodycj
Copy link

@brodycj brodycj commented Jan 8, 2024

Thanks in advance for the consideration.

Comment on lines +1289 to 1292
The following exit codes are available for mutmut (as documented for the CLI run command):
* 0 if all mutants were killed (OK_KILLED)
* 1 if a fatal error occurred
* 2 if one or more mutants survived (BAD_SURVIVED)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this info would now be duplicated by the changes I proposed to the main run function, which I think is where this info belongs to be accessible to the user. I would be happy to trim down or remove the info here, if needed.

print()
print("To show the results: mutmut results")
print()
print("To generate HTML report: mutmut html")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines I don't like. Won't this output that help message ALWAYS? That's wrong.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now removed. I had thought this could be helpful for newcomers, just like mutmut results shows how to show and apply a surviving mutant. Maybe another, shorter hint could be ideal, even if it just says to do mutmut --help for pointers on what to do next.

@brodycj brodycj force-pushed the improve-high-level-documentation branch from d096ab1 to bbf6e91 Compare January 9, 2024 07:08
@brodycj
Copy link
Author

brodycj commented Jan 9, 2024

I have removed the extra output from the end of mutmut run, merged changes from master, and rebased. Please let me know if you have any further questions or concerns. Yes one of my objectives has been to make this as intuitive as possible for newcomers.

@boxed boxed merged commit aea85c0 into boxed:master Jan 9, 2024
3 checks passed
@boxed
Copy link
Owner

boxed commented Jan 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants