Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Jump to last unwatched TV episode" bug #371

Closed
oscahie opened this issue Jan 14, 2013 · 4 comments
Closed

"Jump to last unwatched TV episode" bug #371

oscahie opened this issue Jan 14, 2013 · 4 comments

Comments

@oscahie
Copy link

oscahie commented Jan 14, 2013

This feature works mostly great, but there's a small bug. When you play the automatically selected episode and use the remote to abort playback, the same episode is still selected. However, if you let the episode play till the end so that Boxee exits to the TV show list by itself, then whatever episode is at the top of the list gets selected instead.

@boxeehacks
Copy link
Owner

We don't get any signals from Boxee back about when playback has stopped, so we don't know how we exit or even when we exit video playback. So whatever happens afterwards is just boxee's default behaviour which we cannot change...

@oscahie
Copy link
Author

oscahie commented Feb 2, 2013

I don't think the issue is related to exit signals but instead to how the "last unwatched" episode is selected via scripting. My gut tells me something is off here because if I navigate into a show and then manually change the selected episode then the bug does not occur.

@oscahie
Copy link
Author

oscahie commented Feb 19, 2013

In version 1.46 this issue is now occurring always after watching any episode, regardless of what triggered the end of the playback. You can actually see how initially the played item is still selected but about a second later the selection is moved to whatever episode is on top of the list.

This feature as it stands now is pretty much broken. Or am I really the only one with such issue?

@oscahie
Copy link
Author

oscahie commented Feb 20, 2013

Ok, I finally decided to look myself into this issue and managed to implement a workaround. I'm also refactoring the rest of the code around selecting the last unwatched item for better clarity and performance, soon will submit the patch.

oscahie pushed a commit to oscahie/boxeehack that referenced this issue Feb 20, 2013
… item (issue boxeehacks#371)

Additionally reworked the code that searches for the last unwatched
episode for better performance and readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants