[FIX] Set expiry for site transient #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Details ------------ The site transient had no expiry date, which meant that if no file changes were detecetd by `scandir($mudir)` then the old key would continue to be used. I have set this to have an expiry of 1 day so that if this does happen eventually new code will be loaded, but with a 1 day expiry the performance impact is minimal. An example of this happening is that if a file already exists in `mu-plugins` but doesn't have the appropriate **plugin name** comment then the file is included in the scandir results, but not loaded by WP because of the missing comment. A later change to add the comment to the file does not prompt the loader to load the file. Backout Plan ----------- Revert of this commit will restore previous behaviour without impact.
jdamner
force-pushed
the
transient-expiration
branch
from
2dcffc9 to
8f25e01
Compare
jonny-bull
approved these changes
May 19, 2023
|
This is nice |
Ritchbox
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Details
The site transient had no expiry date, which meant that if no file changes were detecetd by
scandir($mudir)then the old key would continue to be used.I have set this to have an expiry of 1 day so that if this does happen eventually new code will be loaded, but with a 1 day expiry the performance impact is minimal.
An example of this happening is that if a file already exists in
mu-pluginsbut doesn't have the appropriate plugin name comment then the file is included in the scandir results, but not loaded by WP because of the missing comment. A later change to add the comment to the file does not prompt the loader to load the file.Backout Plan
Revert of this commit will restore previous behaviour without impact.