Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 #17

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Support PHP 8.0 #17

merged 1 commit into from
Jul 5, 2021

Conversation

leoloso
Copy link

@leoloso leoloso commented Jul 5, 2021

I'm running PHP 8 in my server, so I submit this simple PR to add support for it.

I deployed it already (pointing to my feature branch) to my site in production, and it works alright.

Please notice: PHP 8.0 doesn't work for development, since the require-deved package codeclimate/php-test-reporter is stuck on PHP 7.

@jenkoian
Copy link

jenkoian commented Jul 5, 2021

Thanks @leoloso and for testing it on your site. I don't think that codeclimate stuff is used at all anyway, so will look to get rid of that.

@jenkoian jenkoian merged commit ac6b6f7 into boxuk:master Jul 5, 2021
@leoloso
Copy link
Author

leoloso commented Jul 5, 2021

Thanks @jenkoian. Do you plan to create a new tag?

@jenkoian
Copy link

jenkoian commented Jul 5, 2021

@leoloso yep, just removing that codeclimate stuff, tag should be done within an hour.

@leoloso
Copy link
Author

leoloso commented Jul 5, 2021

Lovely, thanks

@jenkoian
Copy link

jenkoian commented Jul 5, 2021

@leoloso
Copy link
Author

leoloso commented Jul 5, 2021

Beautiful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants