[FEATURE] Include the surge caching plugin by default. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonny-bull
reviewed
Dec 21, 2021
Comment on lines
+73
to
+75
| Surge won't work on VIP environments as it needs the ability to write to the file system. [VIP has its own page caching anyhow](https://docs.wpvip.com/technical-references/caching/page-cache/). | ||
|
|
||
| `composer remove wpackagist-plugin/surge` |
There was a problem hiding this comment.
Is there anything that can be done to detect the VIP environment and switch this off in those circumstances?
There was a problem hiding this comment.
We could do this automatically in the vip-install, although it may still be useful to have installed locally. I think it'd likely be part of our deployment script to remove as part of that.
There was a problem hiding this comment.
Which (at the moment at least) I think is outside of the scope of this repository.
There was a problem hiding this comment.
Yeah, that's reasonable.
jonny-bull
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kovshenin/surge