[DEPS] Updates Roots to use new full installation option #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like we can remove |
|
@anthonywnz ... now that would make an awful lot of sense 🤦🏻 |
|
Hmm... Maybe not... Or maybe we just need https://packagist.org/packages/roots/wordpress-core-installer too? Let me know if you want me to pick this up :) (since you're generally very busy lol) |
|
I think that's it, see the requirements section on https://packagist.org/packages/roots/wordpress-full
|
|
@anthonywnz ... nice. I've just added that and built locally. Seems like the tests are happy too. |
anthonywnz
approved these changes
Aug 24, 2022
PeteWJ
force-pushed
the
update-roots-to-use-full-install
branch
from
7849826 to
2da5516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roots WordPress installation package has removed the default installation of themes, and therefore does not create the
wp-contentfolder expected by the installer. This results inwp core installfailing as it is unable to find expected folders.The old approach - bundling the themes - is available as a separate package:
roots/wordpress-fullThis PR changes to that new package.
Details of the change in the package can be found here https://roots.io/updates-to-roots-wordpress-composer-package/