Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP] Remove PHP 7.4, make PHP 8.0 the default installation #328

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

jonny-bull
Copy link
Contributor

@jonny-bull jonny-bull commented Nov 16, 2022

Sets 8.0 to the default version of PHP used when installing a fresh skeleton

Removes the deprecated PHP 7.4

@jonny-bull jonny-bull force-pushed the php8-default branch 2 times, most recently from bec769b to b7b7d00 Compare November 16, 2022 14:37
@jonny-bull jonny-bull changed the title [SETUP] Make PHP 8.0 the default installation [SETUP] Remove PHP 7.4, make PHP 8.0 the default installation Nov 16, 2022
@jonny-bull jonny-bull force-pushed the php8-default branch 3 times, most recently from ced980d to d5cefa0 Compare November 16, 2022 16:09
Copy link

@sunilverma209 sunilverma209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@dansmart-box dansmart-box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonny-bull
Copy link
Contributor Author

Thanks @dansmart-box @martisim and @sunilverma209 for helping make sure that 8.1 build works

@jonny-bull jonny-bull merged commit efe917d into main Nov 16, 2022
@jonny-bull jonny-bull deleted the php8-default branch November 16, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants