Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove temporary files #12

Closed
boyska opened this issue Jul 20, 2016 · 1 comment
Closed

remove temporary files #12

boyska opened this issue Jul 20, 2016 · 1 comment
Labels
bug

Comments

@boyska
Copy link
Owner

boyska commented Jul 20, 2016

audiogens typically create temporary files. We should remove them when they have been played. This is not a simple task, because we cannot be sure that after a certain time they would have been played (the dj might put other music before that). Other solutions include:

  • when a file:/// whose path starts with $TMPDIR "leaves" the playlist it, remove it. The case in which someone will re-insert it is irrelevant. This makes it VERY important to have our own specific TMPDIR; removing things in /tmp/ is bad.
  • just delete after 3 hours. Yes, that might still be on the playlist. Who cares.
@boyska boyska added the bug label Jul 21, 2016
boyska added a commit that referenced this issue Sep 14, 2016
@boyska
TMPDIR not random and more observed
5c6f9b7 
tempfile module caches gettempdir() at startup, so we need to be explicit.
refs #12
boyska added a commit that referenced this issue Sep 14, 2016
@boyska
remove tmp files when they leave playlist
e35834a 
however, this doesn't work consistently across larigira restarts: you should expect that restarting larigira
will cause leftover files to remain.
refs #12
@boyska
Copy link
Owner Author

boyska commented Sep 14, 2016

with latest commits, the issue has become much smaller: only leftovers between larigira restarts left. While this is still suboptimal, it's at least clearly delimited.

boyska added a commit that referenced this issue Sep 19, 2016
@boyska
clean tmpfiles from continous_audiospec
949efa0 
refs #22, #12
@boyska boyska closed this as completed Feb 4, 2017
@boyska boyska mentioned this issue Feb 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boyska