[dsccommunity#1331] Code review fixes.

bozho · Apr 25, 2019 · 099c1fc · 099c1fc
1 parent 100ccf8
commit 099c1fc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1 b/DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1
@@ -688,8 +688,13 @@ function Set-TargetResource
             }
         }
 
-        if ( $restartReportingService -and (-not $SuppressRestart) )
+        if ( $restartReportingService -and $SuppressRestart )
         {
+            Write-Warning -Message $script:localizedData.SuppressRestart
+        }
+        elseif ( $restartReportingService -and (-not $SuppressRestart) )
+        {
+            Write-Verbose -Message $script:localizedData.Restart
             Restart-ReportingServicesService -SQLInstanceName $InstanceName -WaitTime 30
         }
     }

diff --git a/DSCResources/MSFT_SqlRS/en-US/MSFT_SqlRS.strings.psd1 b/DSCResources/MSFT_SqlRS/en-US/MSFT_SqlRS.strings.psd1
@@ -0,0 +1,6 @@
+# Localized resources for SqlSetup
+
+ConvertFrom-StringData @'
+    Restart = Restarting Reporting Services.
+    SuppressRestart = Suppressing restart of Reporting Services.
+'@
diff --git a/README.md b/README.md
@@ -775,7 +775,7 @@ Initializes and configures SQL Reporting Services server.
 * **`[Boolean]` UseSsl** _(Write)_: If connections to the Reporting Services must
   use SSL. If this parameter is not assigned a value, the default is that Reporting
   Services does not use SSL.
-* **`[Boolean]` SupressRestart** _(Write)_: Reporting Services need to be restarted
+* **`[Boolean]` SuppressRestart** _(Write)_: Reporting Services need to be restarted
   after initialization or settings change. If this parameter is set to $true,
   Reporting Services will not be restarted, even after initialisation.