Skip to content

Commit

Permalink
[dsccommunity#1258] A fix for Reporting Services initialization on SQ…
Browse files Browse the repository at this point in the history
…L Standard and lower editions
  • Loading branch information
bozho committed Apr 26, 2019
1 parent 874c8aa commit 7e1e8ec
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
- Reporting Services are restarted after changing settings, unless
`$SuppressRestart` parameter is set ([issue #1331](https://github.com/PowerShell/SqlServerDsc/issues/1331)).
`$SuppressRestart` will also prevent Reporting Services restart after initialization.
- Fixed ([issue #1258](https://github.com/PowerShell/SqlServerDsc/issues/1258)).
When initializing Reporting Services, there is no need to execute `InitializeReportServer`
CIM method, since executing `SetDatabaseConnection` CIM method initializes
Reporting Services.
- Changes to SqlServerLogin
- Added en-US localization ([issue #615](https://github.com/PowerShell/SqlServerDsc/issues/615)).
- Added unit tests to improved code coverage.
Expand Down
16 changes: 8 additions & 8 deletions DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -445,15 +445,15 @@ function Set-TargetResource

Invoke-RsCimMethod @invokeRsCimMethodParameters

$invokeRsCimMethodParameters = @{
CimInstance = $reportingServicesData.Configuration
MethodName = 'InitializeReportServer'
Arguments = @{
InstallationId = $reportingServicesData.Configuration.InstallationID
}
}
<#
There is no need to execute `InitializeReportServer` CIM method
here, since executing `SetDatabaseConnection` CIM method initializes
Reporting Services.
Invoke-RsCimMethod @invokeRsCimMethodParameters
A call to `InitializeReportServer` method here will fail on
SQL Standard and lower editions, as Reporting Services will try
to configure scale-out deployment.
#>

if ( $PSBoundParameters.ContainsKey('UseSsl') -and $UseSsl -ne $currentConfig.UseSsl )
{
Expand Down

0 comments on commit 7e1e8ec

Please sign in to comment.