Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No response to tapping a photo or video on iPhone 11, iOS 13.4.1 #155

Closed
ghost opened this issue May 11, 2020 · 9 comments
Closed

No response to tapping a photo or video on iPhone 11, iOS 13.4.1 #155

ghost opened this issue May 11, 2020 · 9 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented May 11, 2020

Describe the bug
When I tap on a photo in a collection on an iPhone 11, I expect it to be shown (almost) full screen, but nothing appears to happen. When I tap on the white triangle in a video, I expect it to start playing, but nothing appears to happen either.

This behavior is regardless of the collection, user or whether Safari, Chrome or Firefox is used. The same photos and videos behave as expected an Android phone as well as a notebook.

Environment (please complete the following information):

  • OS: Server: Linux 5.6.11,
  • Browser: Safari, Chrome and Firefox

Used app version:

  • bpatrik/pigallery2:latest
  • docker version 19.03.8-ce
@bpatrik bpatrik added the bug label May 22, 2020
@bpatrik
Copy link
Owner

bpatrik commented May 22, 2020

Thanks for the report. It does not sound good. I'll look into it.

@macxs
Copy link

macxs commented Aug 8, 2020

I‘ve got the same issue on iOS 13.5.1 iPhone Xr having the same setup as @misterwrong but also on the demo instance.

@helmut72
Copy link

helmut72 commented Dec 8, 2020

It only works when you press with two fingers at the thumbnail, at least on an iPad.

@FelixUster
Copy link

FelixUster commented Mar 16, 2021

It only works when you press with two fingers at the thumbnail, at least on an iPad.

After you figured this out, I've tried this within the PiGallery2 Demo and it seems that all buttons and actions are activated by tapping with two fingers.

@bpatrik
Copy link
Owner

bpatrik commented Apr 4, 2021

The issue seems to be with leaflet / yaga-map (library used for showing the map.
I want to eventually replace it to https://github.com/Asymmetrik/ngx-leaflet or something similar as yaga-map is not well maintained. But that requires the Angular CLI to be updated: bluehalo/ngx-leaflet#273 and for that I need to refactor i18n (translation) which will be a lot of work.

For now, I disabled map preview for IOS (replaced it with an ugly icon). This seems to resolve the issue.

bpatrik added a commit that referenced this issue Apr 4, 2021
leaflet (yaga-map) uses z-index that confuses safari on IOS and prevents click propagation for photo preview (lightbox)
@macxs
Copy link

macxs commented Apr 9, 2021

Thanks a lot! Successfully tested on the demo instance

@bpatrik
Copy link
Owner

bpatrik commented May 2, 2021

I updated the maps in #256.
I quickly tested it on an old iPad. It seems to work. Can you confirm?

@bpatrik bpatrik added this to the v1.9 milestone May 2, 2021
@macxs
Copy link

macxs commented May 2, 2021

Works perfectly. Huge thanks for your efforts!

@bpatrik bpatrik closed this as completed May 3, 2021
@MainAero
Copy link

Having this issue again in v1.9.3. Can only play videos on iOS when tapping with two fingers. As well the other controls (i.e close) are only working when tapping with two fingers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants