Database (shares, albums, etc.) are lost on upgrade

[SlavikCA]

Describe the bug
I'm running piGallery2 via Docker.
DB mounted to the host:

version: '3'
services:
  pigallery2:
    image: bpatrik/pigallery2:nightly-alpine
    volumes:
      - /volume1/hosting/piGallery2/config:/app/data/config
      - /volume1/hosting/piGallery2/db-data:/app/data/db
      - /volume1/pix/Photos_Personal:/app/data/images:ro
      - /volume1/hosting/piGallery2/cache:/app/data/tmp
    environment:
      NODE_ENV: production

Every time I pull new version of the image and restart the container - all my shares are lost.

I can't point to exact builds
Now I'm on commit f2ab96f.
I'll recreate few shares now and we'll try later with another version in a few days again.

Can the issue be because I'm using nightly builds? Will shares be preserved if I use LATEST tag for Docker image instead?

[SlavikCA]

Also, I think the indexing info is lost on update, too.
But I'll have to verify / confirm that... Is it expected to be preserved? Should re-indexing be run after upgrade?

[bpatrik]

yeah its kinda what it is. If the DB structure changes, the app just drops the DB (including shares). Proper upgrade/migration queries would needed to fix it. Last time I checked typeorm could not really deal with it by default and I do not have the time fixing it.

If you find this annoying, use releases (latest docket tag) instead of nightly, so that you do not get off guard by a DB drop.

[bpatrik]

more precisely, if this number changes

pigallery2/src/common/DataStructureVersion.ts

Lines 1 to 4 in f2ab96f

	/**
	* This version indicates that the SQL sql/entities/*Entity.ts files got changed and the db needs to be recreated
	*/
	export const DataStructureVersion = 25;

, you loose your DB:

pigallery2/src/backend/model/database/sql/SQLConnection.ts

Lines 154 to 179 in f2ab96f

	if (version && version.version === DataStructureVersion) {
	return;
	}
	Logger.info(LOG_TAG, 'Updating database scheme');
	if (!version) {
	version = new VersionEntity();
	}
	version.version = DataStructureVersion;
	let users: UserEntity[] = [];
	try {
	users = await connection.getRepository(UserEntity).createQueryBuilder('user').getMany();
	} catch (ex) {
	}
	await connection.dropDatabase();
	await connection.synchronize();
	await connection.getRepository(VersionEntity).save(version);
	try {
	await connection.getRepository(UserEntity).save(users);
	} catch (e) {
	await connection.dropDatabase();
	await connection.synchronize();
	await connection.getRepository(VersionEntity).save(version);
	Logger.warn(LOG_TAG, 'Could not move users to the new db scheme, deleting them. Details:' + e.toString());
	}
	}

[SlavikCA]

If you find this annoying, use releases (latest docket tag) instead of nightly, so that you do not get off guard by a DB drop.

I looked at the code, and it appears, that even if I use LATEST tag, the DB would drop too (if DataStructureVersion gets incremented). It just would do it less frequently. Right?

[bpatrik]

unfortunately, yes. There are no upgrade scripts implemented.
It is the same / related issue to: #301 (comment)

[bpatrik]

I renamed the issue to better reflect the actual problem and added a note in the docker README.md so it will catch less people off-guard a6dc01b.

[bpatrik]

closing this due to inactivity. Feel free to reopen if you think otherwise.