Negative EXIF ratings cause DB malfunction

[desertwitch]

Negative EXIF ratings such as -1, which are used by few rare clients for marking images for deletion, cause folder indexing queries to fail because tinyint database field does not tolerate negative values, only positive values from 0 to 255. As part of this problem the image with negative EXIF rating and all following images of that folder are not indexed into the DB.

driverError: Error: ER_WARN_DATA_OUT_OF_RANGE: Out of range value for column 'metadataRating' at row 1

• Solution A: Change field type in database from tinyint (1 byte) to smallint (2 byte) to allow negative ratings too and stay true to actual rating of image.
• Solution B: Always override negative ratings to 0 because negative ratings are useless, not staying true to actual rating of image - see my pull request.

[bpatrik]

I prefer solution B (min value should be 0) as client only works with value between 0 and 5 P

…

-- Sorry for being brief, sent from my phone. Veronika ***@***.***> ezt írta (időpont: 2022. jan. 18., K 12:53):

Negative EXIF ratings, which are used by few rare clients for marking images for deletion, cause folder indexing queries to fail because *tinyint* database field does not tolerate negative values, only positive from 0 to 255. *driverError: Error: ER_WARN_DATA_OUT_OF_RANGE: Out of range value for column 'metadataRating' at row 1* - Solution A: Change field type in database from *tinyint* (1 byte) to *smallint* (2 byte) to allow negative ratings too. - Solution B: Always change negative ratings to 0 because negative ratings are useless, see my pull request. — Reply to this email directly, view it on GitHub <#409>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZKA5X6J6QTIS3TQFUIDQLUWVIDJANCNFSM5MG65O6A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[desertwitch]

fixed #410