Split out build info into another module #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
force-pushed
the
build_info
branch
3 times, most recently
from
1cf1f14 to
814b5bf
Compare
|
Gonna merge this tomorrow if there's no objections. The broken |
|
Looks ok, go for it:) |
7c40e2a ("build: Share core bpftrace code with test binary") broke the libbpf build info b/c libbpftrace target wasn't given the libbpf cmake vars. This commit splits out the buildinfo such that the buildinfo is only needed inside libbpftrace target. This is nicer b/c then we don't have to pass cmake vars to multiple targets. It's also nicer b/c main.cpp is less concerned with internal details like build flags. Also note that this commit also defines LLVM_VERSION_* preprocessor variables. I'm not sure where those variables were coming from (maybe one of the llvm header files). It's probably better we define it ourselves so things are more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7c40e2a ("build: Share core bpftrace code with test binary")
broke the libbpf build info b/c libbpftrace target wasn't given
the libbpf cmake vars.
This commit splits out the buildinfo such that the buildinfo is only
needed inside libbpftrace target. This is nicer b/c then we don't have
to pass cmake vars to multiple targets. It's also nicer b/c main.cpp
is less concerned with internal details like build flags.
Also note that this commit also defines LLVM_VERSION_* preprocessor
variables. I'm not sure where those variables were coming from (maybe
one of the llvm header files). It's probably better we define it
ourselves so things are more explicit.
Checklist
docs/reference_guide.mdCHANGELOG.md