Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): document role privileges required by proxmox_virtual_environment_download_file #1442

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

windowsrefund
Copy link
Contributor

Follow up on #1439

Copy link

conventional-commit-lint-gcf bot commented Jul 15, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@windowsrefund Thanks for adding this!

I've updated the PR and moved this new section under the download_file resource doc.

Also, the PR checks shows that you have not signed-off the commit (DCO check), but I'll ignore it for now as this is a pretty minor change (that I've updated anyway :)

@bpg bpg changed the title docs: document role privileges required by proxmox_virtual_environment_down… fix(docs): document role privileges required by proxmox_virtual_environment_download_file Jul 16, 2024
@bpg bpg merged commit 2475d99 into bpg:main Jul 16, 2024
8 checks passed
@bpg
Copy link
Owner

bpg commented Jul 16, 2024

@all-contributors please add @windowsrefund for docs

Copy link
Contributor

@bpg

I've put up a pull request to add @windowsrefund! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants