Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): Don't add an extra hostpci entry #223

Merged
merged 1 commit into from
Feb 5, 2023
Merged

fix(vm): Don't add an extra hostpci entry #223

merged 1 commit into from
Feb 5, 2023

Conversation

qazbnm456
Copy link
Contributor

When I try to clone from a template with no hostpci in the config, the post body would contain an extra hostpci because of these lines (from DefaultFunc).

image


Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

When I try to clone from a template with no `hostpci` in the config, the post body would contain an extra `hostpci` because of these lines (from `DefaultFunc`).
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Feb 1, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@codecov-commenter
Copy link

Codecov Report

Base: 11.20% // Head: 11.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e3b7225) compared to base (11fe9e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   11.20%   11.21%           
=======================================
  Files          54       54           
  Lines       11726    11716   -10     
=======================================
  Hits         1314     1314           
+ Misses      10386    10376   -10     
  Partials       26       26           
Impacted Files Coverage Δ
proxmoxtf/resource_virtual_environment_vm.go 1.92% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bpg
Copy link
Owner

bpg commented Feb 5, 2023

Caused by #194

Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qazbnm456, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants