fix(sdn): fix subnet datasource IP address datatype

[maciej-lech]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

testacc.log

example.log

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[gemini-code-assist]

Summary of Changes

Hello @maciej-lech, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a fix for the SDN subnet data source by refining its schema definition. The primary goal is to ensure that IP address-related fields are correctly typed and validated, enhancing the reliability of network configurations. To validate and showcase these improvements, a comprehensive example configuration has also been added, demonstrating the functionality of the updated data source.

Highlights

• SDN Subnet Data Source Schema Refinement: The schema for the sdn_subnet data source has been updated to explicitly use customtypes.IPAddrType for the dhcp_dns_server, dhcp_range's start_address and end_address, and gateway attributes. This ensures proper type handling and validation for IP address fields.
• New Example Configuration Added: A new example Terraform configuration file (example/data_source_virtual_environment_sdn.tf) has been introduced. This file demonstrates the correct usage and functionality of various SDN data sources, including sdn_zone_simple, sdn_zones, sdn_vnet, and the sdn_subnet data source that was fixed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes the SDN subnet data source by adding custom type validation for IP address fields, which is a good improvement for data integrity. The changes to the Go source files are correct. I've found a small copy-paste error in the new example Terraform file and have provided a suggestion to fix it.

[bpg]

Thanks for the fix @maciej-lech! 👍🏼

LGTM! 🚀

[bpg]

@all-contributors please add @maciej-lech for test, code

[allcontributors]

@bpg

I've put up a pull request to add @maciej-lech! 🎉