-
-
Notifications
You must be signed in to change notification settings - Fork 232
misc(test): use ubuntu minimal cloud image in tests #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(test): use ubuntu minimal cloud image in tests #2311
Conversation
4a61e6e to
634aaad
Compare
|
My life would be simpler with a leaner cloud image. 😆 |
|
Maybe something similar can be done for lxc tests as well? Containers use templates from |
634aaad to
c2e9ef4
Compare
|
Good call updating the tests! Not sure about the changes in docs and guides tho. People come here from different backgrounds, and many may start with copy/pasting an example, which may not produce a VM they expect. Also I remember some issues in 22.04 vs 24.04 around cloud-init and/systemd behaviour in new versions, some examples might require additional adjustments, like adding serial device, or something. |
|
I ran several tests, but not all of them—I don’t remember exactly which ones :). I’m fine with reverting the documentation changes. |
Signed-off-by: Ehsan Poursaeed <hsnprsd@gmail.com>
1518426 to
e955290
Compare
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Yup, alpine container image works just fine, I'll update it in a separate PR. |
@bpg I have already done that in the PR with lxc tests refactoring: #2320 |
bpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run acceptance test and examples, everything seems to be ok 👌🏼
LGTM! 🚀
I've also tried minimal ubuntu in the lxc examples, and it seems to be working fine. Tho alpine is better / smaller :) |
Contributor's Note
/docsfor any user-facing features or additions./fwprovider/testsfor any new or updated resources / data sources.make exampleto verify that the change works as expected.Proof of Work
Community Note
Closes #0000 | Relates #0000