fix(lxc): fixes for datastore-backed volume mounts

[bpg]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated templates in /example for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

resource "proxmox_virtual_environment_container" "test_container" {
  node_name = var.virtual_environment_node_name

  disk {
    datastore_id = "local-lvm"
    size         = 8
  }

  started = false

  description = <<-EOT
		some
		desc
  EOT

  initialization {
    hostname = "test"

    ip_config {
      ipv4 {
        address = "dhcp"
      }
    }
  }

  network_interface {
    name = "vmbr0"
  }

  operating_system {
    template_file_id = "local:vztmpl/ubuntu-20.04-standard_20.04-1_amd64.tar.gz"
    # template_file_id = proxmox_virtual_environment_file.ubuntu_container_template.id
    type             = "ubuntu"
  }

  mount_point {
    volume = "local-lvm"
    size   = "4G"
    path   = "/mnt/local"
  }

  unprivileged = true
}

❯ terraform apply -auto-approve
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - bpg/proxmox in /Users/pasha/go/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with
│ published releases.
╵

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # proxmox_virtual_environment_container.test_container will be created
  + resource "proxmox_virtual_environment_container" "test_container" {
      + description   = <<-EOT
            some
            desc
        EOT
      + id            = (known after apply)
      + node_name     = "pve"
      + start_on_boot = true
      + started       = false
      + template      = false
      + unprivileged  = true
      + vm_id         = -1

      + disk {
          + datastore_id = "local-lvm"
          + size         = 8
        }

      + initialization {
          + hostname = "test"

          + ip_config {
              + ipv4 {
                  + address = "dhcp"
                }
            }
        }

      + mount_point {
          + backup    = true
          + path      = "/mnt/local"
          + quota     = false
          + read_only = false
          + replicate = true
          + shared    = false
          + size      = "8G"
          + volume    = "local-lvm"
        }

      + network_interface {
          + bridge     = "vmbr0"
          + enabled    = true
          + firewall   = false
          + mtu        = 0
          + name       = "vmbr0"
          + rate_limit = 0
          + vlan_id    = 0
        }

      + operating_system {
          + template_file_id = "local:vztmpl/ubuntu-20.04-standard_20.04-1_amd64.tar.gz"
          + type             = "ubuntu"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.
proxmox_virtual_environment_container.test_container: Creating...
proxmox_virtual_environment_container.test_container: Still creating... [10s elapsed]
proxmox_virtual_environment_container.test_container: Creation complete after 11s [id=101]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Re-apply the same plan:

❯ terraform apply -auto-approve
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - bpg/proxmox in /Users/pasha/go/bin
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with
│ published releases.
╵
proxmox_virtual_environment_container.test_container: Refreshing state... [id=101]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

In Proxmox UI:

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #760
Relates to #394

[bpg]

@all-contributors please add @redpimpernel for testing

[allcontributors]

@bpg

I've put up a pull request to add @redpimpernel! 🎉

[mergify]

🤖 LGTM! beep boop