Fixup set env GitHub actions warning #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… folder name Add Mlos.Cpp.Binplace.targets for to binplace native projects. Resolve property BinplaceRootDir after including Microsoft.Cpp or Microsoft.NET.Sdk, so the Plaftorm propery is always set. Add option SkipBinplaceSettingsRegistry (do not binplace Mlos.NetCore). CakeBuild, when creating nuget spec, verify if there are files in the provided path. Include missing .inl file in vcxproj.
Fix Linux warnings (except unknown pragmas)
Remove static fields from MlosContext class. Create a static Mlos Instance field (workaround until we have Experiment class).
Remove usage of auto from c++ files, remove Mlos.Agent.Server from nuget lib folder (it is present in bin folder)
…est for CoreXT builds Set correctly SettingsAssemblyBinplaceDir in Mlos.Test for CoreXT builds
Remove ApplicationFilePath from SettingsAssembly config. Mlos.Agent.Server is using env variable to locate settings assembly registry.
Remove unused file
Some followup work to PR !444061 and additional minor fixups. - Update the docs to reference the new paths - Make `cmake` aware of the `target/bin/` placed items - Fixup some `cmake` dotnet parallel build issues by changing which target references the dependencies (`dotnet build` has issues when invoked in parallel) - Start removing references to the `MLOS_SETTINGS_REGISTRY_PATH` environment variable - Make sure the `Mlos.Agent.Server` exits non-zero if one of the components or `Mlos.Agent` fails
Adding standard comments in Net.Core projects Removing the following exceptions from the analyzer's rules. SA1623 The property's documentation should begin with: Gets (or Sets) SA1633 The file header is missing or not located at the top of the file CA1801 Parameter of method is never used
Continuation of Brian's work bpkroth/more-cpp-compiler-warning-fixups. Enable clang compilation flags: -Wall -Wextra -Wpedantic -Werror. Remove macros from Mlos.Core. Rename variable name from elementLength to elementDataSize.
Works around some CI issues with "dotnet tool" commands for Cake build with older dotnet versions on older Ubuntu 16.04 ADO runners and similar issues for cmake. TODO: This will need additional fixes in the future. We still have the setup-cmake.sh, setup-dotnet.sh type of scripts which can install local copies, but we've started the process of stripping use of those out of the build system. One benefit of those is that they also allow us to fetch (pin) an explicit version (though that was probably a security issue) and use that version even if the default system repo lists don't have a newer version for us. A more complete fix will be to include the logic to check for an appropriate version in the existing system repos (not just existence of the package), and if it doesn't exist add the necessary package repos as well.
* work to add external project notebooks to the website menus * tweak some of the formatting a tad * copy the leveldb notebook images into place * convert them to markdown style links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.