Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (properties/IdProps) : add hint for the process ID field in the Camunda 7 properties Panel #1043

Conversation

prakashpalanisamy
Copy link
Contributor

@prakashpalanisamy prakashpalanisamy commented Apr 15, 2024

Closes #1038

Note Not Appearing for the ID field in the Default Behaviour of the Property Panel:
bpmn-io-properties-generic

Note Appearing for the ID field in the Camunda 7.x modeler - Process level:
image

Note Not Appearing for the ID field in the Camunda 7.x modeler - Activity level:
image

Note Not Appearing for the ID field in the Camunda 8.x modeler - Process level:
image

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I left a single suggestion so that we don't duplicate the code unnecessarily.

Please shorten the commit message so that it does not overflow:

image

The "properties panel." part can be removed. Also there is no need for a dot at the end of the commit message.

src/provider/camunda-platform/properties/IdProps.js Outdated Show resolved Hide resolved
src/provider/camunda-platform/utils/ValidationUtil.js Outdated Show resolved Hide resolved
@barmac
Copy link
Member

barmac commented Apr 23, 2024

To make this solution complete, we should also add a hint in the participant's process ID entry:

image

@nikku
Copy link
Member

nikku commented Apr 26, 2024

@prakashpalanisamy Do you want to follow-up on the review comments? What I believe is missing is to consider #1043 (comment). We could of course also merge the solution as is.

@prakashpalanisamy
Copy link
Contributor Author

@barmac , @nikku I'm on vacation this week. I'll push the updates on Monday next week.

@brianwarner brianwarner force-pushed the Add-Documentation-to-Desktop-Modeler-ID-field branch from 1ba01aa to 341551b Compare May 2, 2024 15:27
@prakashpalanisamy
Copy link
Contributor Author

@prakashpalanisamy Do you want to follow-up on the review comments? What I believe is missing is to consider #1043 (comment). We could of course also merge the solution as is.

@nikku : I have addressed the Participant Process ID issue along with the latest changes. Please take a look. thanks!

@prakashpalanisamy
Copy link
Contributor Author

Camunda 7 Process ID hint displays
image

Camunda 7 Participant Process ID hint displays
image

Camunda 7 hint NOT displayed for Collaboration ID
image

Camunda 8 Process ID hint NOT displayed
image

Camunda 8 Participant Process ID hint NOT displayed
image

Camunda 8 hint for Collaboration ID NOT displayed
image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Process ID
image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Participant Process ID
image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Collaboration ID
image

@barmac
Copy link
Member

barmac commented May 6, 2024

Thanks! I will have a look at this today.

@barmac
Copy link
Member

barmac commented May 9, 2024

I merged this via 23c3974. Thank you for your contribution!

@barmac barmac closed this May 9, 2024
@prakashpalanisamy
Copy link
Contributor Author

I merged this via 23c3974. Thank you for your contribution!

Thank you @barmac & @nikku for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note for ProcessID Field in the Properties Panel
3 participants