feat(modeling): keep interrupting config when replacing elements #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
smbea and
barmac
and removed request for
a team
|
We could decide if it is a breaking change that |
|
Do you know if it's breaking any extension? I'd say that the previous behavior was bug-like. If I want to change type of my element, I shouldn't implicitly change other attributes. |
|
I don't think it is breaking any extensions. Let's consider the previous behavior a bug and make it a minor release |
barmac
approved these changes
Nov 2, 2023
Closed
This was referenced Nov 3, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new features:
Keep the interrupting state when replacing elements, when the interrupting state is not explicitly set. This is used when element-templates are applied to events
Add a toggle header button to non-interrupting events
related to bpmn-io/bpmn-js-element-templates#20
You can try out the integration with element templates here: https://marstamm.github.io/non-interrupting-modeling-demo/